Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Cody Web issue with @-mention menu appearing behind tabs bar #5739

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

sqs
Copy link
Member

@sqs sqs commented Sep 28, 2024

The removal of z-index: 1 is what was needed, and I don't see why other elements would be on top of this tab bar or its popovers.

The other diffs are from stylelint.

atmention-zindex-issue

Test plan

Test that @-mentions are not clipped by the tabs bar in pnpm -C web dev.

The removal of `z-index: 1` is what was needed, and I don't see why other elements would be on top of this tab bar or its popovers.

The other diffs are from stylelint.
Copy link
Contributor

@vovakulikov vovakulikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it was needed for Safari tooltips overlaps, but since then layout has changed a bit and it's no longer needed (Checked manually in Safari within Sourcegraph web)

@sqs sqs merged commit be5fd7f into main Sep 29, 2024
19 checks passed
@sqs sqs deleted the sqs/mentions-clip branch September 29, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants