Use transform when mapping Map values
#728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following warning generated when tapir is being used with Scala 2.13: ``` method mapValues in trait MapOps is deprecated (since 2.13.0): Use .view.mapValues(f). A future version will include a strict version of this method (for now, .view.mapValues(f).toMap) ``` I am using tapir in my project with warnings-as-errors enabled. This warning prevents me from using `.in(formBody[...])` with case classes. The idea to switch to `transform` which is compatible with Scala 2.11, 2.12 and 2.13 was originally found here: scala/scala-collection-compat#216 (comment)
|
Released in 0.16.16, thanks! |
|
Thanks for the quick release!
…On Wed, 26 Aug 2020, 19:55 Adam Warski, ***@***.***> wrote:
Released in 0.16.16
<https://github.com/softwaremill/tapir/releases/tag/v0.16.16>, thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#728 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADHBRSIOBNCIVN3UXALYV3SCU47HANCNFSM4QLVZPLQ>
.
|
2m
added a commit
to 2m/auto-gate
that referenced
this pull request
Aug 26, 2020
Use latest tapir and case class for request form data as it now does not give warnings anymore after softwaremill/tapir#728 has been merged and released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following warning generated when tapir is being
used with Scala 2.13:
I am using tapir in my project with warnings-as-errors enabled. This
warning prevents me from using
.in(formBody[...])with caseclasses.
The idea to switch to
transformwhich is compatible with Scala 2.11,2.12 and 2.13 was originally found here: scala/scala-collection-compat#216 (comment)