Codegen: serialize empty arrays and require them (jsoniter fix) #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughsimpson
commented
Apr 4, 2024
| reqJsonBody shouldEqual """{"d":23.4,"i":123,"s":"a string"}""" | ||
| respJsonBody shouldEqual """{"d":23.4,"i":123,"s":"a string+SubtypeWithoutD3"}""" | ||
| reqJsonBody shouldEqual """{"absent":null,"d":23.4,"i":123,"s":"a string"}""" | ||
| respJsonBody shouldEqual """{"absent":null,"d":23.4,"i":123,"s":"a string+SubtypeWithoutD3"}""" |
There was a problem hiding this comment.
Arguably could attempt to configure circe to omit these for great consistency; however I feel like that's going too far, and I think it's reasonable behaviour that can sanely differ between json lib implementations.
hughsimpson
force-pushed
the
codegen_serialize_empty_arrays_and_require_them-jsoniter-fix
branch
from
d44ac64
to
813376a
Compare
hughsimpson
deleted the
codegen_serialize_empty_arrays_and_require_them-jsoniter-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct follow-up to #3647 - uses new tests to validate implied expectations around required array fields. 'Real' diff is just the last commit here.
Whether this is really the right behaviour may be up for debate, although the new behaviour is the same as that expected by the non-discriminated-oneOf validation code, which will otherwise need to be made more convoluted/draconian.