Skip to content

Commit

Permalink
Fix broken links in Contributing.md
Browse files Browse the repository at this point in the history
  • Loading branch information
giraffate authored and calebcartwright committed Dec 17, 2020
1 parent 81ad114 commit 2e0aa5f
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions Contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ Rustfmt is basically a pretty printer - that is, its mode of operation is to
take an AST (abstract syntax tree) and print it in a nice way (including staying
under the maximum permitted width for a line). In order to get that AST, we
first have to parse the source text, we use the Rust compiler's parser to do
that (see [lib.rs in rustfmt-lib](rustfmt-core/rustfmt-lib/src/lib.rs)). We shy away from doing anything too fancy, such as
that (see [lib.rs](src/lib.rs)). We shy away from doing anything too fancy, such as
algebraic approaches to pretty printing, instead relying on an heuristic
approach, 'manually' crafting a string for each AST node. This results in quite
a lot of code, but it is relatively simple.
Expand Down Expand Up @@ -226,19 +226,19 @@ At a higher level, Rustfmt has machinery so that we account for text between
'top level' items. Then we can reproduce that text pretty much verbatim. We only
count spans we actually reformat, so if we can't format a span it is not missed
completely but is reproduced in the output without being formatted. This is
mostly handled in [missed_spans.rs](rustfmt-core/rustfmt-lib/src/missed_spans.rs). See also `FmtVisitor::last_pos` in
[visitor.rs](rustfmt-core/rustfmt-lib/src/visitor.rs).
mostly handled in [missed_spans.rs](src/formatting/missed_spans.rs). See also `FmtVisitor::last_pos` in
[visitor.rs](src/formatting/visitor.rs).


#### Some important elements

At the highest level, Rustfmt uses a `Visitor` implementation called `FmtVisitor`
to walk the AST. This is in [visitor.rs](rustfmt-core/rustfmt-lib/src/visitor.rs). This is really just used to walk
to walk the AST. This is in [visitor.rs](src/formatting/visitor.rs). This is really just used to walk
items, rather than the bodies of functions. We also cover macros and attributes
here. Most methods of the visitor call out to `Rewrite` implementations that
then walk their own children.

The `Rewrite` trait is defined in [rewrite.rs](rustfmt-core/rustfmt-lib/src/rewrite.rs). It is implemented for many
The `Rewrite` trait is defined in [rewrite.rs](src/formatting/rewrite.rs). It is implemented for many
things that can be rewritten, mostly AST nodes. It has a single function,
`rewrite`, which is called to rewrite `self` into an `Option<String>`. The
arguments are `width` which is the horizontal space we write into and `offset`
Expand Down Expand Up @@ -296,15 +296,15 @@ Much of the syntax in Rust is lists: lists of arguments, lists of fields, lists
array elements, etc. We have some generic code to handle lists, including how to
space them in horizontal and vertical space, indentation, comments between
items, trailing separators, etc. However, since there are so many options, the
code is a bit complex. Look in [lists.rs](rustfmt-core/rustfmt-lib/src/lists.rs). `write_list` is the key function,
code is a bit complex. Look in [lists.rs](src/formatting/lists.rs). `write_list` is the key function,
and `ListFormatting` the key structure for configuration. You'll need to make a
`ListItems` for input, this is usually done using `itemize_list`.

##### Configuration

Rustfmt strives to be highly configurable. Often the first part of a patch is
creating a configuration option for the feature you are implementing. All
handling of configuration options is done in [lib.rs in rustfmt-config](rustfmt-core/rustfmt-config/src/lib.rs). Look for the
handling of configuration options is done in [config.rs](src/config.rs). Look for the
`create_config!` macro at the end of the file for all the options. The rest of
the file defines a bunch of enums used for options, and the machinery to produce
the config struct and parse a config file, etc. Checking an option is done by
Expand Down

0 comments on commit 2e0aa5f

Please sign in to comment.