CcProtoLibrary: Don't add dynamic librarys to filesToBuild on Windows

bazelbuild#3985 Change-Id: Ib566103e147219122b3f745a98ad30db5f27553f PiperOrigin-RevId: 176365079
smilexin · Nov 20, 2017 · 9738f35 · 9738f35
1 parent 4117c86
commit 9738f35
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 7 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CcLibraryHelper.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CcLibraryHelper.java
@@ -245,15 +245,25 @@ public CppCompilationContext getCppCompilationContext() {
     }
 
     /**
-     * Adds the static, pic-static, and dynamic (both compile-time and execution-time) libraries to
-     * the given builder.
+     * Adds the static, pic-static libraries to the given builder.
+     * If addDynamicLibraries parameter is true, it also adds dynamic(both compile-time and
+     * execution-time) libraries.
      */
-    public void addLinkingOutputsTo(NestedSetBuilder<Artifact> filesBuilder) {
+    public void addLinkingOutputsTo(
+        NestedSetBuilder<Artifact> filesBuilder, boolean addDynamicLibraries) {
       filesBuilder
           .addAll(LinkerInputs.toLibraryArtifacts(linkingOutputs.getStaticLibraries()))
-          .addAll(LinkerInputs.toLibraryArtifacts(linkingOutputs.getPicStaticLibraries()))
-          .addAll(LinkerInputs.toNonSolibArtifacts(linkingOutputs.getDynamicLibraries()))
-          .addAll(LinkerInputs.toNonSolibArtifacts(linkingOutputs.getExecutionDynamicLibraries()));
+          .addAll(LinkerInputs.toLibraryArtifacts(linkingOutputs.getPicStaticLibraries()));
+      if (addDynamicLibraries) {
+        filesBuilder
+            .addAll(LinkerInputs.toNonSolibArtifacts(linkingOutputs.getDynamicLibraries()))
+            .addAll(
+                LinkerInputs.toNonSolibArtifacts(linkingOutputs.getExecutionDynamicLibraries()));
+      }
+    }
+
+    public void addLinkingOutputsTo(NestedSetBuilder<Artifact> filesBuilder) {
+      addLinkingOutputsTo(filesBuilder, true);
     }
   }
 

diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/proto/CcProtoAspect.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/proto/CcProtoAspect.java
@@ -190,7 +190,9 @@ private static class Impl {
       CcLibraryHelper.Info info = helper.build();
       ccLibraryProviders = info.getProviders();
       outputGroups = info.getOutputGroups();
-      info.addLinkingOutputsTo(filesBuilder);
+      // On Windows, dynamic library is not built by default, so don't add them to filesToBuild.
+      info.addLinkingOutputsTo(
+          filesBuilder, !featureConfiguration.isEnabled(CppRuleClasses.TARGETS_WINDOWS));
     }
 
     private boolean areSrcsBlacklisted() {