fix: issue #107 #108
fix: issue #107 #108
Conversation
| } | ||
| return u, err | ||
| return u, nil |
There was a problem hiding this comment.
@christiangda why not leaving it as such ? "return u, err" ?
| } | ||
| return g, err | ||
| return g, nil |
There was a problem hiding this comment.
@christiangda why not leaving it as such ? "return g, err" ?
|
|
||
| return m, err | ||
| return m, nil |
There was a problem hiding this comment.
@christiangda why not leaving it as such ? "return m, err" ?
There was a problem hiding this comment.
Hello @christiangda ,
The fix looks solid to me and this definitely explains why some groups were deleted and other were not during the same program execution. I checked how the function "Pages()" is reacting upon error, and it always gives an error when an HTTP error code is different from 2xx, which is ok for me 👍
|
Hello @christiangda , We have been running the idp-scim with the changes over the past 2 months, and we have not had any issues, everything is running smoothy. Could you merge the PR ? :pray. Thank you in advance, |
|
+1 From my side too; we had no issues of groups being deleted and recreated randomly. |
This should fix issue #107 , but it is hard to test mocking the Google API method #107