Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run getSecrets not only as lambda #80

Closed
nerdingasnate opened this issue Aug 22, 2022 · 1 comment · Fixed by #81
Closed

feat: run getSecrets not only as lambda #80

nerdingasnate opened this issue Aug 22, 2022 · 1 comment · Fixed by #81
Assignees
Labels
enhancement New feature or request feature New feature or request
Milestone

Comments

@nerdingasnate
Copy link

Is your feature request related to a problem? Please describe.
I am trying to run idp-scim-sync in a k8s pod, but it does not work as it expects to have a credentials.json locally instead of an aws secret as when running like aws lambda.

Describe the solution you'd like
I would like for it to use environment variables to read secrets if they are set as it does when running like a aws lambda

Describe alternatives you've considered
I tried faking pod being a lambda with _LAMBDA_SERVER_PORT, but that just hangs
There is also option of creating a secret in k8s and mounting that as a file, but would go against our best practices

Additional context

@nerdingasnate nerdingasnate added enhancement New feature or request feature New feature or request labels Aug 22, 2022
christiangda added a commit that referenced this issue Aug 28, 2022
@christiangda
Copy link
Contributor

christiangda commented Aug 28, 2022

hi @nerdingasnate, thank you very much for trying to use this software in k8s.

I created #81 with an initial implementation of this feature.

Could you try to build this locally and test this implementation before I continue?

You will find new flags in the idpscim program, among which is -g, --use-secrets-manager use AWS Secrets Manager content or not (default: false)

And let me know if this works for you!

How to

After cloning the repo, use the PR branch

git clone git@github.com:slashdevops/idp-scim-sync.git
git checkout issue-#80

Make local binary

make

Check new flags

./build/idpscim --help 

Build a local image container, and check the warning message below!

# WARNING: this is necessary because the docker tag cannot contain the '#' character
git checkout -b issue80

make container-build   

Check fresh container images

docker images

@christiangda christiangda self-assigned this Aug 28, 2022
@christiangda christiangda added this to the v0.0.15 milestone Aug 28, 2022
@christiangda christiangda linked a pull request Aug 28, 2022 that will close this issue
christiangda added a commit that referenced this issue Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants