It seems that the aar/classes.jar should NOT include the R class #235
+58
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uildConfig. If the R is included, dex will fail with an error about finding the same R in multiple jars. I haven't really found anyone saying this explicity nor any docs that say as much. I do have a gradle build that depends on an aar that is generated with this mojo that will fail if R is in the classes.jar. I also know that the android gradle build tools combine resources. The only other evidence I have that hints at not including R is the following discussion on google groups: https://groups.google.com/forum/#!msg/adt-dev/uWppd9l8UNw/w6Q_9N13mLcJ
|
Yup that seems correct, at the time I thought it had to be included. Thanks for the fix |
|
Great... thanks. We still need to get that sample project going.. just wondering if I should cut a release with this and flag the aar support as experiemental? wdyt? |
mosabua
added a commit
that referenced
this pull request
Sep 27, 2013
It seems that the aar/classes.jar should NOT include the R class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think the aar/classes.jar should include the R classes. If the R is included, dex will fail with an error about finding the same R in multiple jars.
I haven't really found anyone saying this explicitly nor any docs that say as much. I do have a gradle build that depends on an aar that is generated with this mojo that will fail if R is in the classes.jar. I also know that the android gradle build tools combine resources. The only other evidence I have that hints at not including R is the following discussion on google groups:
https://groups.google.com/forum/#!msg/adt-dev/uWppd9l8UNw/w6Q_9N13mLcJ