Remove commented out sections in CI configs #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanato
approved these changes
Oct 28, 2021
|
FWIW I kept those lines, commented out, in case anyone wanted to perform pivkey-enabled builds and encountered a compilation error for want of that lib |
Signed-off-by: Jason Hall <jasonhall@redhat.com>
imjasonh
force-pushed
the
remove-commented-out
branch
from
738fb48
to
5dece55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes some potentially confusing commented out sections in some CI configs.
These sections were commented out in #332
Release Note