Yubikey management CLI #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
force-pushed
the
piv-key
branch
13 times, most recently
from
bd3edd1
to
ef42693
Compare
|
Removing the WIP! This is good to go. Wee can track the remaining TODOs (including actual signing support) in #108 |
priyawadhwa
approved these changes
Apr 9, 2021
| "testing" | ||
|
|
||
| // Import the functions directly for testing. | ||
| . "github.com/sigstore/cosign/cmd/cosign/cli/pivcli" |
There was a problem hiding this comment.
cool i haven't seen this before!
Signed-off-by: Dan Lorenc <dlorenc@google.com>
lcarva
pushed a commit
to lcarva/cosign
that referenced
this pull request
Sep 10, 2024
* fix(SECURESIGN-1179): include version metadata The konflux build does not include all the necessary metadata for the `cosign version` command. This change should ensure that the command produces the correct information. Signed-off-by: Lance Ball <lball@redhat.com> * chore: remove k8s v1.24 from e2e tests The upstream has completely refactored the e2e tests. We have not pulled those changes in due to the fact that they haven't been included in a released version yet. However, since the last pull from upstream, k8s v1.24 is no longer supported in the version of kind being used in the tests. This commit removes that version from the tests but otherwise leaves them unchanged. Signed-off-by: Lance Ball <lball@redhat.com> * chore: update image for whitespace check Signed-off-by: Lance Ball <lball@redhat.com> --------- Signed-off-by: Lance Ball <lball@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new set of subcommands for working with PIV tokens. They currently live under:
cosign piv-toolRight now we have:
cosign piv-tool set-management-keycosign piv-tool set-pukcosign piv-tool set-pincosign piv-tool unblockcosign piv-tool generate-keycosign piv-tool attestationThey seem to work pretty well! Before merging, I want to do a bit more work on the UX itself, including:
Then a "nice to have" would be a way to disable OTP on the keys :) They get angry whenacciccccccrikcvulenljchtvbbetejhevulebrvbrrkrkevdentally pressed.
Also, tests and stuff probably.
Signed-off-by: Dan Lorenc dlorenc@google.com