Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tree command utility #1603

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Conversation

developer-guy
Copy link
Member

@developer-guy developer-guy commented Mar 14, 2022

Fixes #1569

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

Screen Shot 2022-03-14 at 12 14 11

Summary

This PR will display the Supply Chain Security related artifacts for an image including Signatures, Attestations and SBOMs

Ticket Link

Fixes #1569

Release Note

feat: tree command utility

@developer-guy developer-guy self-assigned this Mar 14, 2022
cmd/cosign/cli/tree.go Outdated Show resolved Hide resolved
@developer-guy developer-guy force-pushed the feature/1569 branch 2 times, most recently from ce21081 to e2488bf Compare March 14, 2022 11:17
cmd/cosign/cli/tree.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, i am not sure of the command's name. But i don’t have any alternative name.

@developer-guy developer-guy force-pushed the feature/1569 branch 2 times, most recently from 6504a04 to 23da12a Compare March 15, 2022 07:42
@hectorj2f
Copy link
Contributor

Fixes sigstore#1569

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Co-authored-by: Hector Fernandez <hectorj@gmail.com>
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@haydentherapper
Copy link
Contributor

Is there an existing command this could go under, like triangulate? It seems unnecessary to me that this have a dedicated command.

@developer-guy
Copy link
Member Author

It is more like a fun command to help people visualize every supply chain artifact related to an image in a unified way. Although, IMHO, the naming of that command is nice, triangulate only outputs the reference of an artifact, not visualize the whole tree, WDYT?

@haydentherapper
Copy link
Contributor

They seem very related to me - Both commands are about providing more information about the OCI artifact.

@dlorenc dlorenc merged commit be77bb0 into sigstore:main Mar 22, 2022
@github-actions github-actions bot added this to the v1.7.0 milestone Mar 22, 2022
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Fixes sigstore#1569

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Co-authored-by: Hector Fernandez <hectorj@gmail.com>
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>

Co-authored-by: Hector Fernandez <hectorj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tree command to display all the supply chain security artifacts
4 participants