Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No hook key needed when using precompiled hooks #48

Merged
merged 2 commits into from
Oct 30, 2021

Conversation

minuscorp
Copy link
Collaborator

I have rewritten the flow of the execution to allow Komondor to fit the new PackageConfig capability of using precompiled binaries which might have hooks recorded in them that Komondor does not find in the Package.swift. This way we just warn the user that the hook did nothing and exit gracefully of the hook. It still exits with an error if cannot find the komondor key under the configuration being loaded.

@orta
Copy link
Member

orta commented Oct 29, 2021

Yeah, cool looks good.

I was initially suspicious about the test removal but they were a NOOP anyway👍🏻

@minuscorp
Copy link
Collaborator Author

I have no permissions to either merge or release on this repo so it's up to you! 😄

@orta
Copy link
Member

orta commented Oct 29, 2021

Hah, OK, I'll need to be at another computer to do this so I'll add you and ship when I get back

@orta orta merged commit 3fd3482 into shibapm:master Oct 30, 2021
@orta
Copy link
Member

orta commented Oct 30, 2021

@orta
Copy link
Member

orta commented Oct 30, 2021

think that's everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants