Fix for issue #110 - Wheel Zoom Direction For Skew and Hodo Widgets #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd wheel down is zoom out for both the hodo and skewt
…his is consistent with the same logic in setProfileCollection method above it. Without this return statement when a profile does not exist to be removed it continues on after the except and triggers errors in the following code since pc_idx variable is never set.
|
Sorry for the confusion...figuring out pull requests. It looks like it added my other fix since it was all in my master branch. The second commit fixes a bug in SPCWindow. Without this return statement when a profile does not exist to be removed it continues on after the except and triggers errors in the following code since pc_idx variable is never set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified hodo.py wheelEvent so zoom direction on mouse wheel for skewt and hodo are consistent