PostfixDeref: direct dereference #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the release of PPR v0.001000 there is a backwards incompatible
change in the definition of the `PerlTerm` rule to include postfix
arrows for dereferencing and methods.
This affects the plugin(s):
$ git grep -lP '\b(Perl)?(Term|((ScalarAccess|ArrayAccess)(NoSpace)?))' lib/
lib/Babble/Plugin/PostfixDeref.pm
Newer PPR handles the postfix dereference in `PerlTerm` while `PerlScalarAccess` handles indexing without any arrows. This also addresses the issue of <shadow-dot-cat#3>. This adds the tests from that PR (djerius++). Co-authored-by: Diab Jerius <djerius@cfa.harvard.edu>
For PostfixDeref that is interpolated in quote-likes.
Using `map` to translate the postfix subscripts does not work with
`push`, `pop`, `shift`, `unshift`, `splice`, and other built-ins that
modify the parameter as the `map` is using a copy.
This change makes the translation of
```perl
$foo->$*
```
into
```perl
${ $foo }
```
instead of
```perl
(map $$_, $foo)[0]
```
Fixes <shadow-dot-cat#13>.
zmughal
added a commit
to zmughal/Babble
that referenced
this pull request
Sep 4, 2022
…-access PostfixDeref: direct dereference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented on top of #12.
mapFixes #13.