Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send sentry_timestamp in the header. #28

Merged
merged 2 commits into from
Dec 14, 2019
Merged

Don't send sentry_timestamp in the header. #28

merged 2 commits into from
Dec 14, 2019

Conversation

15joeybloom
Copy link
Contributor

Previously sentry_timestamp in the header was sent in the format 2019-12-13 12:02:58.94. This suddenly stopped working on 12/12 around 16:45 CST.

Sentry's documentation (see the Authentication section) says that the sentry_timestamp should be a UNIX timestamp. We tried sending 0 and that worked just fine, but we also tried not sending sentry_timestamp at all and that also worked.

Here is a PR removing sentry_timestamp from the header. What do you think?

@martinklepsch
Copy link
Collaborator

Thanks! I think I’d lean towards a PR that keeps sending the timestamp since in some situations that might be helpful information and different from when it was received by sentry (which is what I assume they default to if you don’t provide it).

Would that work for you and would you be open to create a PR for that?

@15joeybloom
Copy link
Contributor Author

Yeah that works for me! Here's the new version, sending the current time in UNIX format.

@15joeybloom
Copy link
Contributor Author

@martinklepsch
Copy link
Collaborator

Thanks, deployed with 1.6.0-alpha4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants