remove unnecessary weakself

selvamsankaran · Nov 16, 2017 · e0d31f4 · e0d31f4
1 parent 22abbf7
commit e0d31f4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 14 deletions.
diff --git a/invites/InvitesExample/AppDelegate.m b/invites/InvitesExample/AppDelegate.m
@@ -48,17 +48,13 @@ - (BOOL)application:(UIApplication *)application
                                  annotation:annotation]) {
     return YES;
   }
-  // [START_EXCLUDE silent]
-  __weak AppDelegate *weakSelf = self;
-  // [END_EXCLUDE]
   // Handle App Invite requests
   return [FIRInvites handleUniversalLink:url
                                       completion:^(FIRReceivedInvite * _Nullable receivedInvite,
                                                    NSError * _Nullable error) {
     // [START_EXCLUDE]
     if (receivedInvite) {
-      AppDelegate *strongSelf = weakSelf;
-      [strongSelf showAlertViewWithInvite:receivedInvite];
+      [self showAlertViewWithInvite:receivedInvite];
     }
     // [END_EXCLUDE]
   }];
@@ -69,17 +65,13 @@ - (BOOL)application:(UIApplication *)application
 - (BOOL)application:(UIApplication *)application
     continueUserActivity:(NSUserActivity *)userActivity
       restorationHandler:(void (^)(NSArray *))restorationHandler {
-  // [START_EXCLUDE silent]
-  __weak AppDelegate *weakSelf = self;
-  // [END_EXCLUDE]
   // Handle App Invite requests
   return [FIRInvites handleUniversalLink:userActivity.webpageURL
                                       completion:^(FIRReceivedInvite * _Nullable receivedInvite,
                                                    NSError * _Nullable error) {
     // [START_EXCLUDE]
     if (receivedInvite) {
-      AppDelegate *strongSelf = weakSelf;
-      [strongSelf showAlertViewWithInvite:receivedInvite];
+      [self showAlertViewWithInvite:receivedInvite];
     }
     // [END_EXCLUDE]
   }];

diff --git a/invites/InvitesExampleSwift/AppDelegate.swift b/invites/InvitesExampleSwift/AppDelegate.swift
@@ -43,14 +43,14 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
       return true
     }
 
-    return Invites.handleUniversalLink(url) { [weak self] invite, error in
+    return Invites.handleUniversalLink(url) { invite, error in
       // [START_EXCLUDE]
       if let error = error {
         print(error.localizedDescription)
         return
       }
       if let invite = invite {
-        self?.showAlertView(withInvite: invite)
+        self.showAlertView(withInvite: invite)
       }
       // [END_EXCLUDE]
     }
@@ -60,14 +60,14 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
   // [START continueuseractivity]
   @available(iOS 8.0, *)
   func application(_ application: UIApplication, continue userActivity: NSUserActivity, restorationHandler: @escaping ([Any]?) -> Void) -> Bool {
-    return Invites.handleUniversalLink(userActivity.webpageURL!) { [weak self] invite, error in
+    return Invites.handleUniversalLink(userActivity.webpageURL!) { invite, error in
       // [START_EXCLUDE]
       if let error = error {
         print(error.localizedDescription)
         return
       }
       if let invite = invite {
-        self?.showAlertView(withInvite: invite)
+        self.showAlertView(withInvite: invite)
       }
       // [END_EXCLUDE]
     }