Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rewritten] PR #504 #576

Merged
merged 4 commits into from
Mar 29, 2017
Merged

[rewritten] PR #504 #576

merged 4 commits into from
Mar 29, 2017

Conversation

guedou
Copy link
Member

@guedou guedou commented Mar 23, 2017

This PR adds unit tests to PR#504 and small fixes to dhcp6.py

@codecov-io
Copy link

codecov-io commented Mar 23, 2017

Codecov Report

Merging #576 into master will increase coverage by 1.35%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
+ Coverage   74.72%   76.07%   +1.35%     
==========================================
  Files         125      130       +5     
  Lines       30380    31369     +989     
==========================================
+ Hits        22700    23864    +1164     
+ Misses       7680     7505     -175
Impacted Files Coverage Δ
scapy/layers/dhcp6.py 59.05% <100%> (+0.39%) ⬆️
scapy/layers/inet6.py 77.87% <100%> (+0.23%) ⬆️
scapy/contrib/mpls.py 95% <100%> (+33.88%) ⬆️
scapy/layers/l2.py 81.45% <100%> (+1.25%) ⬆️
bin/UTscapy 100% <0%> (ø)
scapy/tools/__init__.py 100% <0%> (ø)
scapy/arch/winpcapy.py 94.61% <0%> (ø)
scapy/arch/windows/__init__.py 75.6% <0%> (ø)
scapy/arch/windows/compatibility.py 77.04% <0%> (ø)
scapy/layers/inet.py 64.17% <0%> (+0.08%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75aa97f...1ab629e. Read the comment docs.

@p-l- p-l- merged commit 77b4ce3 into secdev:master Mar 29, 2017
@guedou guedou deleted the PR#504_improved branch September 11, 2017 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants