-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing guidelines improved #2399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2399 +/- ##
==========================================
- Coverage 87.67% 87.39% -0.29%
==========================================
Files 242 242
Lines 50656 50656
==========================================
- Hits 44413 44271 -142
- Misses 6243 6385 +142
|
Ready to be merged! |
guedou
force-pushed
the
guidelines_improved
branch
from
January 6, 2020 19:22
c71a1d1
to
8c008eb
Compare
p-l-
previously approved these changes
Jan 9, 2020
Side note but all references to things like
Seem outdated. They can't do that. We could potentially use the new GitHub issue templates |
@gpotter2 I pushed a new commit that removes the references to github labels. |
gpotter2
approved these changes
Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some modifications to our guidelines: