-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SRDF to exclude collision pairs in robot models #50
Conversation
732f45f
to
bf2cbd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Pinocchio is the GOAT.
srdf_filename = os.path.join(package_dir, "srdf", "panda.srdf") | ||
|
||
collision_model.addAllCollisionPairs() | ||
pinocchio.removeCollisionPairs(model, collision_model, srdf_filename) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is better.
|
||
<end_effector name="end_effector" parent_link="panda_hand_tcp" group="arm"/> | ||
|
||
<disable_collisions link1="panda_hand" link2="panda_leftfinger" reason="Adjacent"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right and I don't seem to get invalid poses in the example IK but I didn't take a close close look
As shown in this example, Pinocchio allows setting collision pair exclusions using SRDF files.
This PR changes the main models (UR5 and Panda) to use such files, and adds a little more detail in the docs.