test: is the leading slash breaking Windows tests?

[jpivarski]

I'll try removing the slash, putting it back in, and if that's it, I'll exclude it on Windows.

It's making paths like

/C:\Users\runneradmin\AppData\Local\Temp\pytest-of-runneradmin\pytest-0\test_fsspec_writing_local_uri_24\some\path\my%E2%80%92file.root

which at some point become D:/C:. Right about here:

C:\Users\runneradmin\miniconda3\envs\test\lib\site-packages\uproot\sink\file.py:53: in __init__
    self._truncate_file(urlpath_or_file_like, **storage_options)
        self       = <uproot.sink.file.FileSink object at 0x00000295EDA4AFD0>
        storage_options = {}
        urlpath_or_file_like = '/C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_fsspec_writing_local_uri_24\\some\\path\\my%E2%80%92file.root'
C:\Users\runneradmin\miniconda3\envs\test\lib\site-packages\uproot\sink\file.py:80: in _truncate_file
    fs.mkdirs(parent_directory, exist_ok=True)
        cls        = <class 'uproot.sink.file.FileSink'>
        fs         = <fsspec.implementations.local.LocalFileSystem object at 0x00000295DEE2BC70>
        local_path = 'D:/C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/test_fsspec_writing_local_uri_24/some/path/my%E2%80%92file.root'
        parent_directory = 'D:/C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/test_fsspec_writing_local_uri_24/some/path'
        storage_options = {}
        urlpath    = '/C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_fsspec_writing_local_uri_24\\some\\path\\my%E2%80%92file.root'

The local_path returned by

uproot5/src/uproot/sink/file.py

Line 78 in 2d34ce4

fs, local_path = fsspec.core.url_to_fs(urlpath, **storage_options)

has D:/C:, and apparently that didn't happen before. Was there a recent change, @martindurant? (It looks like it might have been wrong before, correct now, and this Uproot test has to catch up.)

[jpivarski]

Yes, I've seen enough test results to know that that was it. I think the correct fix is to test a leading \ on Windows and a leading / on Linux and MacOS.

Once this works, I'm going to merge it into main and from there, all of the active PRs so that some of them can get merged.

[jpivarski]

ReadTheDocs is failing because it can't pull this commit from GitHub. ?!?!?!?!?! Okay, I'm just going to merge it, so that I can get this into all of the other PRs.