-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing currency functions for german and french. Adding Currency_Forms for DE, FR and NL. #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 662
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 662
💛 - Coveralls |
Pull Request Test Coverage Report for Build 669
💛 - Coveralls |
sarahberanek
changed the title
Fixing currency functions for german and french.
Fixing currency functions for german and french. Adding Currency_Forms for DE, FR and NL.
Apr 5, 2019
Hi @sarahberanek |
Hi @erozqba - done! :) |
erozqba
approved these changes
Apr 11, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
by Sarah Beranek
Changes proposed in this pull request:
Status
How to verify this change
the same test for French with setting
lang='fr'
or Dutch withlang='nl'
Additional notes
I think for most of the languages if there is only an integer value given the currency should be euro/dollar and not cent per default.
I see that there is a possible option
is_int_with_cents
in theparse_currency_parts
function to address this, which is not used yet.Maybe it is a good idea to propagate this to the specific language
to_currency
functions?If you agree - I can do the changes, if I find the time.