Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo 'seperator' on source code #238

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Fix typo 'seperator' on source code #238

merged 1 commit into from
Jan 23, 2019

Conversation

erozqba
Copy link
Collaborator

@erozqba erozqba commented Jan 19, 2019

Changes proposed in this pull request:

  • Fix typo.

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

@coveralls
Copy link

coveralls commented Jan 19, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 620

  • 8 of 8 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.611%
Totals Coverage Status
Change from base Build 616: 0.0%
Covered Lines: 4762
Relevant Lines: 5048
💛 - Coveralls

pierreduchemin
pierreduchemin approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@pierreduchemin pierreduchemin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used search to check all replacements.
LGTM.

@kkonieczny Can you double check please?

@kkonieczny
Copy link
Contributor

LGTM too

@pierreduchemin pierreduchemin merged commit aa9b882 into master Jan 23, 2019
@erozqba erozqba deleted the fix_typo_seperator branch January 23, 2019 19:36
@eortiz-tracktik eortiz-tracktik mentioned this pull request May 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierreduchemin pierreduchemin pierreduchemin approved these changes

@kkonieczny kkonieczny kkonieczny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erozqba @coveralls @kkonieczny @pierreduchemin