PL: regular names for powers of thousand #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- typo in "kwadryliard" - expanded long scale up to decilliard (10^63) - PEP8 compliance
test for really big number's Polish name
Names for powers of thousand are now built instead of being hardcoded - less error-prone and more concise.
Pull Request Test Coverage Report for Build 611
💛 - Coveralls |
kkonieczny
approved these changes
Jan 18, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # by...
Changes proposed in this pull request:
Status
How to verify this change
Compare with old hardcoded map.
Additional notes
If applicable, explain the rationale behind your change.