Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make home icon accessible #3201

Merged
merged 1 commit into from
Aug 15, 2018
Merged

make home icon accessible #3201

merged 1 commit into from
Aug 15, 2018

Conversation

kdid
Copy link
Contributor

@kdid kdid commented Aug 13, 2018

Fixes #2979

  • Adds role="img" aria-label="txt" to the span containing the background image used for the logo. From what I can tell this is best practice for making background images accessible.

@samvera/hyrax-code-reviewers

@laritakr laritakr merged commit d5d68da into master Aug 15, 2018
@laritakr laritakr deleted the 2979-home-icon branch August 15, 2018 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants