Update file upload buttons to be keyboard tab accessible #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjarling
force-pushed
the
1246-tabbed-focus-add-files-and-folder-buttons
branch
from
876d9c8
to
728dd7b
Compare
adamjarling
force-pushed
the
1246-tabbed-focus-add-files-and-folder-buttons
branch
from
728dd7b
to
98fa9b8
Compare
laritakr
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1246
Updates the file upload buttons to be
<button>elements instead of<span>s. This enables keyboard tabbing through the buttons in document flow, to improve accessibility.@samvera/hyrax-code-reviewers