Allow optional signature when registering notifications #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
commented
Aug 1, 2024
Comment on lines
+62
to
+75
| // 1. Delete previous subscriptions (and by cascade, notification types) | ||
| // to avoid duplicates, and clearing "unknown" subscriptions | ||
| await sql` | ||
| DELETE FROM notification_subscriptions | ||
| WHERE chain_id = ${safe.chainId} | ||
| AND safe_address = ${safe.address} | ||
| AND ( | ||
| signer_address = ${args.signerAddress ?? null} | ||
| OR ( | ||
| signer_address IS NULL | ||
| ) | ||
| ) | ||
| AND push_notification_device_id = ${device.id} | ||
| `; |
There was a problem hiding this comment.
The subscription is still device based so this shouldn't cause issues of "unsubscriptions".
Pull Request Test Coverage Report for Build 10452769483Details
💛 - Coveralls |
Comment on lines
142
to
146
| return this.notificationsDatasource.deleteSubscription({ | ||
| deviceUuid: args.deviceUuid, | ||
| chainId: args.chainId, | ||
| safeAddress: args.safeAddress, | ||
| }); |
There was a problem hiding this comment.
Another small nit, but this could remain as this.notificationsDatasource.deleteSubscription(args), couldn't it?
hectorgomezv
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It should be possible to register for "public" notifications, e.g. incoming/outgoing assets, without a signing key.
This adapts the
POST/v2/register/notificationsendpoint to make theaccessTokenoptional and, if not present, register for notifications as a non-owner/delegate with nosigner_addresssaved. When notifications are dispatched, if nosigner_addressis present, only "public" notifications are therefore dispatch to the related Firebase token.Changes
notification_subscriptions['signer_address']column nullable