wildcard support for directories with preceding / #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request ended up being a lot larger than i originally intended. i'm going to add line comments on where i made changes to support this |
|
|
||
| // TODO: Handle [Rule 4] which negates the match for patterns leading with "!" | ||
| negatePattern := false | ||
| if line[0] == '!' { |
There was a problem hiding this comment.
cleaned this up, so you don't have to cast unnecessarily
sabhiram
added a commit
that referenced
this pull request
Jan 16, 2016
wildcard support for directories with preceding /
|
You are awesome! Thank you for the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this parse doesn't account for the
*operator when there is a preceding/for a directory.For example, if you have
/foo/*.barin your.gitignorefile it should ignore both the/foo/yo.barandfoo/something.barpaths, but right now the parser only ignores/foo/yo.bar.If there is not a preceding
/for a directory, like in this example:bar/*.txtboth
bar/something.txtand/bar/somethingelse.txtare blockedSo this also makes the behavior a little more consistent