Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to Open Source Projects in Readme #222

Merged
merged 3 commits into from
Aug 9, 2020

Conversation

naveen521kk
Copy link
Collaborator

This is much-awaited documentation.
Fixes #218

@vercel
Copy link

vercel bot commented Aug 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/saadpasta/developer-folio/hb0iskpow
✅ Preview: https://developer-folio-git-naveen521kk-update-readme.saadpasta.vercel.app

Copy link
Owner

@saadpasta saadpasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @naveen521kk for taking care of this.

Have you tested the command using in this wiki? Don't you think we should be using both solutions as the .env solution is also working?

@naveen521kk
Copy link
Collaborator Author

The one in the wiki works perfectly, and also you would be doing the same for vercel.

The dotenv AFAIK didn't work for anyone including me. On searching, I found we didn't configure it properly. We would need to add the dependency https://www.npmjs.com/package/dotenv , and configure it, if I'm not wrong.

Maybe, this weekend I will work making it work in that method.

@saadpasta
Copy link
Owner

@naveen521kk It's really weird It's working perfectly for me. I guess it must working for you on local and then when put it on dev the token would be revoked. Is that correct

@naveen521kk
Copy link
Collaborator Author

.env method is working perfectly for me locally.
I haven't pushed it anywhere. But I don't how it doesn't work for others.

@saadpasta
Copy link
Owner

@naveen521kk I think we should keep both the solutions.

Copy link
Collaborator

@kartikcho kartikcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead of removing this section completely from the docs, we can update it with a link to the more "detailed" instructions for the setup.

This would,

  • Save time for users looking for a quick setup and are familiar with environment variables.
  • Wouldn't have a missing section in the readme.

@kartikcho
Copy link
Collaborator

I think we should keep both the solutions.

Same, people in my connections are using this portfolio but had no troubles with the setup. It's still pretty weird seeing users run into that problem.

@naveen521kk
Copy link
Collaborator Author

Maybe, let's say, if the above one fails, go see the wiki page for an alternate one? Will that do?

@saadpasta
Copy link
Owner

Maybe, let's say, if the above one fails, go see the wiki page for an alternate one? Will that do?

Sounds Great 😁

Copy link
Collaborator

@kartikcho kartikcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just address my annoying grammar fix comment haha.

README.md Outdated Show resolved Hide resolved
@naveen521kk naveen521kk merged commit 5b9b67e into master Aug 9, 2020
@naveen521kk naveen521kk deleted the naveen521kk-update-readme branch August 9, 2020 12:57
Mehranmzn pushed a commit to Mehranmzn/mehranmzn.github.io that referenced this pull request Sep 13, 2024
* Update link to Open Source Projects in Readme

* Add an alternate link

* Grammar Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Source Project section is missing
3 participants