-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update link to Open Source Projects in Readme #222
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/saadpasta/developer-folio/hb0iskpow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @naveen521kk for taking care of this.
Have you tested the command using in this wiki? Don't you think we should be using both solutions as the .env solution is also working?
The one in the wiki works perfectly, and also you would be doing the same for vercel. The dotenv AFAIK didn't work for anyone including me. On searching, I found we didn't configure it properly. We would need to add the dependency https://www.npmjs.com/package/dotenv , and configure it, if I'm not wrong. Maybe, this weekend I will work making it work in that method. |
@naveen521kk It's really weird It's working perfectly for me. I guess it must working for you on local and then when put it on dev the token would be revoked. Is that correct |
|
@naveen521kk I think we should keep both the solutions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instead of removing this section completely from the docs, we can update it with a link to the more "detailed" instructions for the setup.
This would,
- Save time for users looking for a quick setup and are familiar with environment variables.
- Wouldn't have a missing section in the readme.
Same, people in my connections are using this portfolio but had no troubles with the setup. It's still pretty weird seeing users run into that problem. |
Maybe, let's say, if the above one fails, go see the wiki page for an alternate one? Will that do? |
Sounds Great 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just address my annoying grammar fix comment haha.
* Update link to Open Source Projects in Readme * Add an alternate link * Grammar Fix
This is much-awaited documentation.
Fixes #218