Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade annotate-snippets to 0.8 #4762

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

JohnTitor
Copy link
Member

Almost the same as #4161 but for 1.4.x.

@calebcartwright calebcartwright changed the base branch from rustfmt-1.4.37 to rustfmt-1.4.38 April 22, 2021 02:31
@calebcartwright
Copy link
Member

Apologies for the delay on this one and also for the subsequent conflict, but there was a separate PR that heavily modified the lockfile that I wanted to get landed.

Whenever you get a chance would you rebase this (on rustfmt-1.4.38)? Otherwise LGTM

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@calebcartwright calebcartwright merged commit ddb224a into rust-lang:rustfmt-1.4.38 Apr 22, 2021
@JohnTitor JohnTitor deleted the annotate-snippets branch April 22, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants