Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to swallow attribute on brace expression #3848

Merged
merged 2 commits into from
Oct 10, 2019
Merged

fix to swallow attribute on brace expression #3848

merged 2 commits into from
Oct 10, 2019

Conversation

rchaser53
Copy link
Contributor

fix: #3845

topecongiro
topecongiro reviewed Oct 8, 2019
View reviewed changes
Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! The fix looks good to me. Would you mind replacing some of your code with the existing function to avoid code duplication?

src/closures.rs Outdated Show resolved Hide resolved
@topecongiro topecongiro added this to the 1.4.10 milestone Oct 10, 2019
@topecongiro topecongiro merged commit 396a2af into rust-lang:master Oct 10, 2019
@topecongiro
Copy link
Contributor

Thank you for the update 🎉

@rchaser53 rchaser53 deleted the issue-3845 branch October 10, 2019 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topecongiro topecongiro topecongiro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.10
Development

Successfully merging this pull request may close these issues.

Attribute on brace expression within closure is swallowed.
2 participants
@rchaser53 @topecongiro