Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the toolstate update bot to rust-highfive #50613

Merged
merged 1 commit into from
May 15, 2018
Merged

Migrate the toolstate update bot to rust-highfive #50613

merged 1 commit into from
May 15, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented May 10, 2018

Rationale: Only members of the rust-lang organization can mention its teams. That means #50434 has no effect if we are still using @kennytm-githubbot.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2018
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented May 10, 2018

📌 Commit 26321af has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2018
kennytm added a commit to kennytm/rust that referenced this pull request May 12, 2018
@kennytm
Rollup merge of rust-lang#50613 - kennytm:update-toolstate-with-highf…
91abeac 
…ive, r=alexcrichton

Migrate the toolstate update bot to rust-highfive

Rationale: Only members of the rust-lang organization can mention its teams. That means rust-lang#50434 has no effect if we are still using @kennytm-githubbot.
@kennytm kennytm mentioned this pull request May 12, 2018
Closed
@Mark-Simulacrum
Copy link
Member

@bors rollup

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 12, 2018
Merged
@kennytm
Copy link
Member Author

kennytm commented May 12, 2018

🤔 https://ci.appveyor.com/project/rust-lang/rust/build/1.0.7376/job/9o088yskmevklcaq

remote: Permission to rust-lang-nursery/rust-toolstate.git denied to rust-highfive.

@Mark-Simulacrum
Copy link
Member

@bors r- rollup-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 12, 2018
bors added a commit that referenced this pull request May 12, 2018
@bors
Auto merge of #50686 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
ff2ac35 
Rollup of 13 pull requests

Successful merges:

 - #50544 (Cleanup some dependencies)
 - #50545 (Made some functions in time module const)
 - #50550 (use fmt::Result where applicable)
 - #50558 (Remove all reference to DepGraph::work_products)
 - #50602 (Update canonicalize docs)
 - #50607 (Allocate Symbol strings from an arena)
 - #50613 (Migrate the toolstate update bot to rust-highfive)
 - #50624 (fs::write: Add example writing a &str)
 - #50634 (Do not silently truncate offsets for `read_at`/`write_at` on emscripten)
 - #50644 (AppVeyor: Read back trace from crash dump on failure.)
 - #50661 (Ignore non .rs files for tidy libcoretest)
 - #50663 (rustc: Allow an edition's feature on that edition)
 - #50667 (rustc: Only suggest deleting `extern crate` if it works)

Failed merges:
@kennytm kennytm force-pushed the update-toolstate-with-highfive branch from 26321af to 201d528 Compare May 13, 2018 06:10
@kennytm

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@kennytm kennytm changed the title Migrate the toolstate update bot to rust-highfive [WIP — checking permission] Migrate the toolstate update bot to rust-highfive May 13, 2018
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-lang rust-lang deleted a comment from rust-highfive May 13, 2018
@kennytm kennytm force-pushed the update-toolstate-with-highfive branch from 201d528 to a89e387 Compare May 13, 2018 08:09
@kennytm

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-lang rust-lang deleted a comment from rust-highfive May 13, 2018
@kennytm
Copy link
Member Author

kennytm commented May 13, 2018

@alexcrichton rust-highfive still cannot push anything even though I've made it a collaborator, and I believe it has accepted the invitation. What else maybe missing?

alexcrichton
alexcrichton reviewed May 14, 2018
View reviewed changes
src/ci/docker/x86_64-gnu-tools/repo.sh Outdated
git config --global user.email '34210020+rust-toolstate-update@users.noreply.github.com'
BRANCH=test

git config --global user.email '7378925+rust-toolstate-update@users.noreply.github.com'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/rust-toolstate-update/rust-highfive/

.... maybe? (unsure)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcrichton The + part is just a comment, and 7378925 is already rust-highfive's user ID :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! I can't think of any other reason though locally why it wouldn't be working...

Maybe I could try regenerating the tokens if this update doesn't work?

@rust-highfive

This comment has been minimized.

Sign in to view
@kennytm

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
bors added a commit that referenced this pull request May 14, 2018
@bors
Auto merge of #50613 - kennytm:update-toolstate-with-highfive, r=<try>
1b68b92 
[WIP — checking permission] Migrate the toolstate update bot to rust-highfive

Rationale: Only members of the rust-lang organization can mention its teams. That means #50434 has no effect if we are still using @kennytm-githubbot.
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-lang rust-lang deleted a comment from rust-highfive May 14, 2018
@bors

This comment has been minimized.

Sign in to view
@kennytm kennytm force-pushed the update-toolstate-with-highfive branch from 859bcd6 to 2ccf71c Compare May 14, 2018 14:35
@kennytm kennytm changed the title [WIP — checking permission] Migrate the toolstate update bot to rust-highfive Migrate the toolstate update bot to rust-highfive May 14, 2018
@kennytm
Copy link
Member Author

kennytm commented May 14, 2018

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented May 14, 2018

📌 Commit 2ccf71c has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 14, 2018
kennytm added a commit to kennytm/rust that referenced this pull request May 14, 2018
@kennytm
Rollup merge of rust-lang#50613 - kennytm:update-toolstate-with-highf…
6daf61b 
…ive, r=alexcrichton

Migrate the toolstate update bot to rust-highfive

Rationale: Only members of the rust-lang organization can mention its teams. That means rust-lang#50434 has no effect if we are still using @kennytm-githubbot.
@kennytm kennytm mentioned this pull request May 14, 2018
Closed
@kennytm
Copy link
Member Author

kennytm commented May 15, 2018

@bors rollup

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 15, 2018
@GuillaumeGomez
Rollup merge of rust-lang#50613 - kennytm:update-toolstate-with-highf…
91c648b 
…ive, r=alexcrichton

Migrate the toolstate update bot to rust-highfive

Rationale: Only members of the rust-lang organization can mention its teams. That means rust-lang#50434 has no effect if we are still using @kennytm-githubbot.
@GuillaumeGomez GuillaumeGomez mentioned this pull request May 15, 2018
Merged
bors added a commit that referenced this pull request May 15, 2018
@bors
Auto merge of #50769 - GuillaumeGomez:rollup, r=GuillaumeGomez
27acb9b 
Rollup of 11 pull requests

Successful merges:

 - #49767 (Rewrite docs for `std::ptr`)
 - #50399 (save-analysis: handle aliasing imports a bit more nicely)
 - #50594 (Update the man page with additional --print options)
 - #50613 (Migrate the toolstate update bot to rust-highfive)
 - #50632 (Add minification process)
 - #50685 (ci: Add Dockerfile for dist-sparc64-linux)
 - #50691 (rustdoc: Add support for pub(restricted))
 - #50712 (Improve eager type resolution error message)
 - #50720 (Add “Examples” section header in f32/f64 doc comments.)
 - #50733 (Hyperlink DOI against preferred resolver)
 - #50745 (Uncapitalize "You")

Failed merges:
@bors bors merged commit 2ccf71c into rust-lang:master May 15, 2018
@kennytm kennytm deleted the update-toolstate-with-highfive branch May 15, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton left review comments

Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kennytm @rust-highfive @alexcrichton @bors @Mark-Simulacrum