Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record Doc Improvements #178

Merged
merged 3 commits into from
May 27, 2017
Merged

Record Doc Improvements #178

merged 3 commits into from
May 27, 2017

Conversation

jehiggs
Copy link
Contributor

@jehiggs jehiggs commented May 27, 2017

This addresses the doc improvements suggested by #129 for the Record structure.

Let me know if there's anything missing or anything that can be improved!

src/lib.rs Outdated
/// }
/// ```
///
/// [`log`]: trait.Log.html#method.log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown links are case insensitive so you can't have both [`log`] and [`Log`]. How about the following?

bla bla [`log`][method.log] method

[method.log]: trait.Log.html#method.log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize that - thanks!

@dtolnay
Copy link
Member

dtolnay commented May 27, 2017

Thank you!

@dtolnay dtolnay merged commit 1389e2d into rust-lang:master May 27, 2017
EFanZh pushed a commit to EFanZh/log that referenced this pull request Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants