Prevent memory impl to access private fields + add missing pub/accessors #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to migrate frontier to the latest version, it seems impossible to implement the
SubstrateStackMetadata
because it cannot access private fieldStackSubstateMetadata.accessed
.This PR contains 2 changes :
Accessed
)MemoryStackSubstate
was "cheating" by accessing private fields ofSubstrateStackMetadata
since it is declared in a submodule. To make it "fair" (= make sure other implementations can access the same fields), I movedexecutor::stack::state
intoexecutor::memory
, and moved the traitStackState
which seemed to be in the wrong place.