Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on invalid date object #317

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Fix crash on invalid date object #317

merged 1 commit into from
Sep 21, 2024

Commits on Sep 21, 2024

  1. Fix crash on invalid date object 

    mini_racer converts JS objects to Ruby objects. Ruby's C API functions
call rb_raise() on invalid inputs, and rb_raise() in turn is a glorified
longjmp() that jumps up the stack.

Longjmp and C++ destructors do not play well together. It left V8 in an
undefined state, resulting in random "Disposing the isolate that is
entered by a thread" fatal errors.

Fixes: rubyjs#316
    @bnoordhuis
    bnoordhuis committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    b485f30 View commit details
    Browse the repository at this point in the history