Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #67.
The commits are incremental and coherent changes, so going commit by commit may be the easiest way to review.
rspec
on this repo, and themspec
on ruby-spec are both passing with these changes.To see the impact easily, edit
ruby-spec/spec/core/hash/compare_by_identity_spec.rb
to only leave the specuses #equal? semantics, but doesn't actually call #equal? to determine identity
. (line 50)Then run
../mspec/bin/mspec --repeat 1000000 core/hash/compare_by_identity_spec.rb
.It should be easy to see the memory that just keeps going up quickly (before this change) using
top
or similar monitoring tool.