WarmResumeManager Unittests + Bugfix #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmalyshev
approved these changes
Oct 30, 2017
| if (frameDataLength > capacity_) { | ||
| resetUpToPosition(lastSentPosition_); | ||
| lastSentPosition_ += frameDataLength; | ||
| firstSentPosition_ += frameDataLength; | ||
| DCHECK(firstSentPosition_ == lastSentPosition_); |
There was a problem hiding this comment.
This and line below should be DCHECK_EQ.
| @@ -71,6 +71,10 @@ class WarmResumeManager : public ResumeManager { | |||
| LOG(FATAL) << "Not Implemented for Warm Resumption"; | |||
| } | |||
|
|
|||
| size_t size() { | |||
There was a problem hiding this comment.
size_t size() const {?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a large frame (larger than the cache size) was received, the firstSentPosition wasn't reset appropriately. Fix it.
Add a suite of unittests.