Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set vertical metrics values to fix line heights on Mac – closes issue #124 #141

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

thundernixon
Copy link
Contributor

Adds misc/glyphs-scripts/set-vertical-metrics.py, a script I initially created for the Encode Sans project to set values based on metric recommendations from @m4rc1e.

Closes #124

image

@rsms
Copy link
Owner

rsms commented Mar 27, 2019

Woah. This is fantastic. I thought #124 would be one of those nightmare issues.
Fingers crossed!

@rsms rsms merged commit fb79b9e into rsms:master Mar 27, 2019
@thundernixon
Copy link
Contributor Author

@rsms I found a lingering issue. #145

I'll make a new PR to really get this right. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants