Makefont improvements #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Could you add a (small) example to show usage? |
|
@einsteinx2 sure, where would you like me to add the example? Here or in the repo somewhere? |
|
Not sure since I don't remember why I asked for a small example. Plus there is already one example and your fix should make it work. Do you have a supplementary example in mind or can I merge your fix ? |
adrianbroher
requested changes
Jan 10, 2020
|
@rougier nope I didn't have anything in mind, you can go ahead and merge it. |
|
Thanks ! Merged ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a few improvements and fixes to
makefont.cincluding fixing this issue: #187