9 Patch - Right Indicator (Content Height Padding) on XXHDPI and XXXHDPI is in #010101 instead of #000000

[taylorling]

Just wanted to file this because we found this issue when the dev having issue importing them into AS for XX and XXX, and turns out the the right indicator line is in #010101 so AS is complaining missing border/wrong color.

[romannurik]

The only thing I can think of is the canvas toDataURL call needs to be more specific w.r.t specifying an output quality (i.e. it should be toDataURL('image/png', 1.0) instead of just toDataURL. Taylor (hi!!!) if you or an engineer you know have bandwidth to try making that change yourself, please give it a go! Otherwise I can hopefully find some time soon to try it.

[taylorling]

Hey Roman (it's been a while 👋 ) - no rush, just thought to file this so if someone having the same issue, they are aware of the issue, and make changes manually.

[romannurik]

I just pushed the change, but not sure if it'll fix it. In case it doesn't, mind sharing a set of repro steps (e.g. with an example source PNG file) so I can try to reproduce the problem?

[romannurik]

OK this should be fully fixed by a4ddd69

[taylorling]

@romannurik Hey buddy, I just give it a try and I still have the same issue.

Here's the source file I used: https://www.dropbox.com/s/xzv60k57mxy53da/btn-blue.png?dl=0

And here's the output zip that I got: https://www.dropbox.com/s/18bgpj25mmjjgc2/btn_blue.9.zip?dl=0

What I did is simply auto stretch, trimming, setting content padding and optical bound, then export. You can see in xxxhdpi, the right indicator is in #010101.

[romannurik]

Hrmmmmm, ok. Will re-open and investigate when I get a chance.

[romannurik]

Hm, Photoshop is showing RGB 0,0,0 for the xxxhdpi right indicator (content padding). Did i mix something up?

[taylorling]

With my 9-patches? If I use Sketch eyedropper on the xxxhdpi asset, it shows me #010101 or RGB 1,1,1 (attached below). If you try to import this asset into AS, it will prompt you that there is a missing color, so it's likely not #000000.

To make sure I didn't inspect the wrong asset, I just ran a fresh generation using the tool again, and it still give me the same result.

[taylorling]

I just tried it on Photoshop and it's indeed showing 0,0,0 and I think it's not correct - if you use the Mac's Digital Color Meter, you can see that it's not entirely 0,0,0 - strange.

[romannurik]

Whoa, super weird. I'll take a look and see if I can fix the problem in Sketch :)

[romannurik]

Finally reproduced the problem... so weird that Photoshop shows 0,0,0.

[romannurik]

OK, the problem is alpha=254, not alpha=255, hence why Photoshop shows 0,0,0. Looking into it

[romannurik]

Should be fixed now.