Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐕 woof woof #7

Open
wants to merge 13 commits into
base: main-nuxt
Choose a base branch
from
Open

🐕 woof woof #7

wants to merge 13 commits into from

Conversation

roiLeo
Copy link
Owner

@roiLeo roiLeo commented Nov 29, 2021

Thank you for your contribution to the KodaDot NFT gallery.

👇 Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested PR on mobile and everything works
  • I found edge cases

What's new?

  • PR closes #<issue_number>
  • <brief_description_of_what_I've_added>

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot for others, is best to understand changes.

@github-actions
Copy link

You're Pull Request scored a 0.005291005291005291 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR:
Boo from Monsters Inc blinking and looking into space neutrally

try {
const { headers } = await api.head(assetUrl)
return headers['content-type']
} catch (e: any) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[eslint] reported by reviewdog 🐶
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any

@@ -1,4 +1,4 @@
import Vue from 'vue'
import MetaInfo from 'vue-meta'

Vue.use(MetaInfo)
Vue.use(MetaInfo);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[eslint] reported by reviewdog 🐶
Extra semicolon. semi

import { APIKeys, pinFile as pinFileToIPFS } from './pinata';
import { extractCid, justHash } from './utils/ipfs';
import Axios from 'axios'
import { NFT, NFTMetadata } from './components/rmrk/service/scheme'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[eslint] reported by reviewdog 🐶
'NFT' is defined but never used. @typescript-eslint/no-unused-vars

import { InjectedAccountWithMeta } from '@polkadot/extension-inject/types';
import { enableExtension } from '@/extension';
import { Component, Vue, Watch } from 'nuxt-property-decorator'
import keyring, { Keyring } from '@polkadot/ui-keyring'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[eslint] reported by reviewdog 🐶
'Keyring' is defined but never used. @typescript-eslint/no-unused-vars

if (/^5/.test(address)) {
return address
}

const ss58Format = store.getters.getChainProperties58Format

return encodeAddress(decodeAddress(address, <any>ss58Format));
return encodeAddress(decodeAddress(address, <any>ss58Format))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[eslint] reported by reviewdog 🐶
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any

protected defaultValues: any[] = [];
protected subs: any = {};
protected keys: any = {}
protected random: any[] = []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[eslint] reported by reviewdog 🐶
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any

protected subs: any = {};
protected keys: any = {}
protected random: any[] = []
protected defaultValues: any[] = []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[eslint] reported by reviewdog 🐶
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any

protected keys: any = {}
protected random: any[] = []
protected defaultValues: any[] = []
protected subs: any = {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[eslint] reported by reviewdog 🐶
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any

}

}

public beforeDestroy() {
Object.values(this.subs).forEach((sub: any) => sub());
Object.values(this.subs).forEach((sub: any) => sub())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[eslint] reported by reviewdog 🐶
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any

const address = typeof account === 'string' ? account : account.address;
const injector = await getAddress(toDefaultAddress(address));
const hasCallback = typeof statusCb === 'function';
try {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[eslint] reported by reviewdog 🐶
Unnecessary try/catch wrapper. no-useless-catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant