WEB3-124: chore: address TODOs #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
nategraf
approved these changes
Sep 13, 2024
Comment on lines
+97
to
98
| // safe conversion: according to the consensus spec, excess_blob_gas is always an uint64 | ||
| blk_env.set_blob_excess_gas_and_price(excess_blob_gas.try_into().unwrap()) |
There was a problem hiding this comment.
Annoying that the upstream header type is factored to use u128. I worry that an unwrap here would become a DoS vector, in that a malformed header could crash the host. I think we should use as u64 instead, to simple truncate the result.
Suggested change
| // safe conversion: according to the consensus spec, excess_blob_gas is always an uint64 | |
| blk_env.set_blob_excess_gas_and_price(excess_blob_gas.try_into().unwrap()) | |
| // safe conversion: according to the consensus spec, excess_blob_gas is always an uint64 | |
| blk_env.set_blob_excess_gas_and_price(excess_blob_gas as u64) |
There was a problem hiding this comment.
I'm not sure, isn't a weird overflow even worse than a clean panic?
If I am a malicious host/RPC, there are so many ways I could make the guest panic, like sending wrong state root or corrupted inclusion proofs, ...
nategraf
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR either resolves the open TODOs, or links them to an GitHub issue.