Dual dummy video support (WebM + MP4) #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By providing two sources the browser can choose the file that is most appropriate for playing the wake lock video. The WebM video, while containing no sound, still captures the screen lock on Android devices.
At least on iOS this works and has the benefit the user's music doesn't stop playing yet it still doesn't sleep
This was referenced Dec 4, 2018
Closed
Closed
alireza-roshanasan
added a commit
to alireza-roshanasan/NoSleep.js
that referenced
this pull request
Jul 18, 2020
|
[ Quote richtr @ CE 2018-12-04 08:01:22 UTC: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents audio interruption on both Android and iOS web browsers while also supporting a wider range of browsers (i.e. Chromium on Android that does not play MP4 files).
Based on the idea presented here: #55 (comment)
Consists of: