Merge Swift42 branch changes #385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator into radianttap-swift-templates
* Don’t import C style headers in Swift code * Add a space between “public” and “private(set)” to avoid “publicprivate” in code. * Don’t declare “open” items in public extension * Use “entityName” instead of “entityName()”
…w types. Intended to fix issue #376
…info key, as described in #375.
Additional fix for #376
|
👋🏻 Hi, what's the status on this PR? I'm building it locally and the generated code is working well though it has warnings with Swift 5. If you're still planning on doing merges I can take a stab at updating the templates for Swift 5 and submitting a PR. |
|
Hi @dginsburg! This PR is more or less ready to merge, I've just been needing someone to test it. If it seems good to you, that's probably all we need. I'll get things moving this week. |
|
I'm happy you feel it's good enough to merge, but you may not want to base that on my experience. I mean it's been fine but this is for a new project and my usage has been basic. |
|
Is there a status update for this? Getting started on a new project and would love to use all the Swift features :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This incorporates a variety of updates to generated Swift code. Objective-C generated code is not affected by this PR. Changes are listed in the updated README and below.
This does not include Codable support for
NSManagedObjectsubclasses, which has been shelved for now.Addresses
[NEW] Update Swift templates for better Swift style (Aleksandar Vacić)
[FIX] Fixed invalid call of
NSManagedObject.fetchRequest()(Vincent Esche)[NEW] Add support for URI and UUID attribute types (Trevor Squires)
[NEW] Expose information when custom type is set through userInfo (Aleksandar Vacić)
[NEW] Add Codable property support via a new attributeCodableTypeName user info key (Tom Harrington)
[CHANGE] Nullability annotations for generated primitive accessors (Michael Babin)
[FIX] Support for “Uses Scalar Type” (Rok Gregorič)
[FIX] Swift 3
NSDatatoData(Christopher Rogers)[FIX] Add specialized
fetchRequest()func to Swift's machine generated files (0xpablo)[FIX] Correct Swift machine template for singleton (fetchOne…) fetch request results (Warren Burton)
[FIX] Expose allAttributes and allRelationships (Trevor Squires)