Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the Objective-C templates #345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updates the Objective-C templates #345

wants to merge 2 commits into from

Conversation

DaveWoodCom
Copy link
Contributor

Summary of Changes

Fixes some syntax errors in the templates introduced in 5fb4229
Prevents creating primativeValue methods that triggers Apple's piss-poor private-API-use detector when submitting to the App Store

Addresses

Similar to #74 and #16
May also want to update mogenerator.m in a similar way to: cd9809d If you'd prefer that, let me know and I can submit a new PR.

@DaveWoodCom
Fix syntax errors in Objective-C templates (missing multiple ]’s)
66834c0
@DaveWoodCom
Just had an app rejected for: `references the following non-public AP…
48bcd6c 
…Is: primitiveValue`, similar to rentzsch#74 and rentzsch#16, so this avoids generating `primativeValue` methods

Wonder if it would be better to amend the main code base similar to this commit?:
rentzsch@cd9809d
@rentzsch
Copy link
Owner

Hey Dave,

That syntax error is embarrassing! Thanks for pointing out a flaw in my test coverage. I just added that coverage, produced the failure, cherry-picked your patch and things are working now.

Yes, I'd prefer to work-around primativeValue the same way primativeType is handled. If you could issue another Pull Request with that, that would be awesome. Be sure to base it off master since noninheritedAttributesSansType changed since cd9809d to print a warning (and should print a warning for primativeValue suppression as well).

@rentzsch rentzsch mentioned this pull request Sep 16, 2016
Open
@atomicbird
Copy link
Collaborator

Hey @DaveWoodCom and @rentzsch, it looks like at least some of this PR was covered in commit b8d4687. Does this PR address anything still outstanding? I don't want to close it if it does but I don't want to leave it open if it's no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaveWoodCom @rentzsch @atomicbird