Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return value of HRANDFIELD With Values when count is negative #3425

Merged
merged 8 commits into from
May 21, 2023

Conversation

s-sathish
Copy link
Contributor

Fix return value of HRANDFIELD With Values when count is negative #3017

@sazzad16 sazzad16 added bug breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. labels May 18, 2023
@sazzad16 sazzad16 added this to the 5.0.0 milestone May 18, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 86.66% and project coverage change: +0.01 🎉

Comparison is base (4ed997c) 64.71% compared to head (a80308e) 64.72%.

❗ Current head a80308e differs from pull request most recent head 5aa9918. Consider uploading reports for the commit 5aa9918 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3425      +/-   ##
============================================
+ Coverage     64.71%   64.72%   +0.01%     
  Complexity     4569     4569              
============================================
  Files           274      274              
  Lines         15254    15279      +25     
  Branches        981      984       +3     
============================================
+ Hits           9871     9890      +19     
- Misses         4968     4973       +5     
- Partials        415      416       +1     
Impacted Files Coverage Δ
.../main/java/redis/clients/jedis/CommandObjects.java 82.31% <ø> (ø)
src/main/java/redis/clients/jedis/Jedis.java 85.46% <ø> (-0.05%) ⬇️
...ava/redis/clients/jedis/MultiNodePipelineBase.java 21.87% <ø> (ø)
src/main/java/redis/clients/jedis/Pipeline.java 16.78% <ø> (ø)
...main/java/redis/clients/jedis/TransactionBase.java 12.01% <ø> (ø)
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 71.42% <ø> (ø)
...dis/clients/jedis/commands/HashBinaryCommands.java 100.00% <ø> (ø)
...ava/redis/clients/jedis/commands/HashCommands.java 100.00% <ø> (ø)
...nts/jedis/commands/HashPipelineBinaryCommands.java 0.00% <ø> (ø)
...s/clients/jedis/commands/HashPipelineCommands.java 0.00% <ø> (ø)
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@s-sathish
Copy link
Contributor Author

Hi @sazzad16 I resolved the conflicts and made changes related to RESP3.
I didn't follow much on the RESP3 protocol and don't have much knowledge on it, so not sure if the changes are aligned properly with it. Please have a look.

@sazzad16
Copy link
Collaborator

@s-sathish Thank you! You did it well 😃

@sazzad16 sazzad16 merged commit 50ec110 into redis:master May 21, 2023
sazzad16 added a commit to sazzad16/jedis that referenced this pull request May 21, 2023
sazzad16 added a commit that referenced this pull request May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants