Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RESP3 protocol through URI/URL #3403

Merged
merged 4 commits into from
May 10, 2023
Merged

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented May 9, 2023

No description provided.

@sazzad16 sazzad16 requested a review from chayim May 9, 2023 13:21
@sazzad16 sazzad16 modified the milestone: 5.0.0 May 9, 2023
@sazzad16 sazzad16 requested a review from chayim May 10, 2023 12:09
@chayim chayim added the feature label May 10, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 56.66% and project coverage change: -0.10 ⚠️

Comparison is base (1cc35a5) 67.66% compared to head (935d703) 67.57%.

❗ Current head 935d703 differs from pull request most recent head 6896944. Consider uploading reports for the commit 6896944 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##                5.0    #3403      +/-   ##
============================================
- Coverage     67.66%   67.57%   -0.10%     
+ Complexity     4749     4746       -3     
============================================
  Files           274      274              
  Lines         15217    15236      +19     
  Branches        979      983       +4     
============================================
- Hits          10297    10296       -1     
- Misses         4491     4508      +17     
- Partials        429      432       +3     
Impacted Files Coverage Δ
src/main/java/redis/clients/jedis/JedisPooled.java 22.72% <0.00%> (-0.53%) ⬇️
.../java/redis/clients/jedis/util/JedisURIHelper.java 73.68% <61.53%> (-7.80%) ⬇️
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 74.41% <66.66%> (-0.05%) ⬇️
src/main/java/redis/clients/jedis/Jedis.java 85.42% <100.00%> (+0.01%) ⬆️
...rc/main/java/redis/clients/jedis/JedisFactory.java 70.32% <100.00%> (+0.32%) ⬆️
...c/main/java/redis/clients/jedis/RedisProtocol.java 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 merged commit b156dcb into redis:5.0 May 10, 2023
@sazzad16 sazzad16 deleted the uri-proto branch May 10, 2023 12:34
@sazzad16 sazzad16 added this to the 5.0.0 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants