Modernize Keyboard subscription, RN v0.65+

[wildseansy]

Summary

React Native 0.65 seems to not support Keyboard.removeListener anymore. Technically it's deprecated, but if you run

console.log(Keyboard.removeListener);

...it produces undefined

Test Plan

What's required for testing (prerequisites)?

• Call useKeyboard within a component that gets destroyed, on React Native v0.65

What are the steps to reproduce (after prerequisites)?

• Run on React Native v0.65, call useKeyboard within a component that then is destroyed via re-render

Compatibility

OS	Implemented
iOS	✅
Android	✅
Web	✅

[gp3gp3gp3]

This change is true of all hooks in this library

[wildseansy]

@gp3gp3gp3 - yes, the other hooks similarly need updates, but they're not as urgent. They are following proper deprecation rules, whereas Keyboard.removeListener seems to have been removed completely, possibly by accident

console.log(Keyboard.removeListener);

..produces undefined (as event emitter now exposes removeListeners)

As far as I have seen, other hooks are still are supported in 0.65 as the API yet been hard-deprecated (although it may emit warnings. Example: useDimensions uses

  Dimensions.addEventListener(...);
  Dimensions.removeEventListener(...);

These functions still exist in react-native@0.65.2.

Relevant:
react-native-community/releases#245 (comment)

This change is true of all hooks in this library

[matinzd]

I think it's time to merge this pr on master.

[wildseansy]

@matinzd - I used to use forEach more, now I follow unicorn lint pretty religiously for standards:
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-array-for-each.md

Happy to make the change though if you prefer forEach

[wojciechkrol]

Hello devs,

Can you merge these changes and release new version of the library?

[LinusU]

Thanks!

[matinzd]

When are you going to release a new version?

[LinusU]

I thought it was going to release automatically since I added the patch label but that seems to be broken 😢

[LinusU]

@pvinis was it you who set up automatic releasing? Or am I just forgetting how it works? 😅

[pvinis]

i think so too 🤔. let me take a look now.

[pvinis]

🚀 PR was released in v2.6.1 🚀

[pvinis]

ok i did a manual release, i hope that worked well. i will try an automatic one to see whats up.

[pvinis]

something is up.. it might need some reconfiguration for automatic releases 🤔

[matinzd]

ok i did a manual release, i hope that worked well. i will try an automatic one to see whats up.

It is still not on npm. Last release is for about year ago!

[KrisLau]

Still getting the error for useKeyboard on react-native: 0.66.3 and @react-native-community/hooks: v2.8.0

EventEmitter.removeListener('keyboardWillShow', ...): Method has been deprecated. Please instead use `remove()` on the subscription returned by `EventEmitter.addListener`. 

[retyui]

@KrisLau

New fix: #279

[KrisLau]

@retyui Thank you I'll upgrade as soon as it gets released!