Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Cache the expensive TPUAcceleratorManager.get_current_node_num_accelerators #46100

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Jun 17, 2024

Why are these changes needed?

TPUAcceleratorManager.get_current_node_num_accelerators is expensive and it doesn't change during the lifetime of the program so we can cache it.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Jun 17, 2024
@jjyao
Copy link
Collaborator Author

jjyao commented Jun 17, 2024

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao merged commit 179b3d5 into ray-project:master Jun 18, 2024
6 checks passed
@jjyao jjyao deleted the jjyao/perrf branch June 18, 2024 02:31
chungen04 pushed a commit to chungen04/ray that referenced this pull request Jun 18, 2024
…_accelerators (ray-project#46100)

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants