[Core] Introduce DictConfigProvider interface for logging config #45736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
can-anyscale
approved these changes
Jun 5, 2024
kevin85421
approved these changes
Jun 5, 2024
| @@ -9,6 +9,7 @@ Core API | |||
| ray.shutdown | |||
| ray.is_initialized | |||
| ray.job_config.JobConfig | |||
| ray.LoggingConfig | |||
There was a problem hiding this comment.
This is the solution for #45344 (comment)
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…-project#45736) Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
yucai
pushed a commit
to yucai/ray
that referenced
this pull request
Jun 6, 2024
…-project#45736) Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: yucai <yyu1@ebay.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…-project#45736) Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
richardsliu
pushed a commit
to richardsliu/ray
that referenced
this pull request
Jun 12, 2024
…-project#45736) Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: Richard Liu <ricliu@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Introduce an interface for providing dict config for supported logging config encodings. Also make LoggingConfig docstring dynamic based on the supported encodings.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.