Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add ray check-open-ports cli #44428

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Apr 2, 2024

Why are these changes needed?

Follow-up of https://www.anyscale.com/blog/update-on-ray-cve-2023-48022-new-verification-tooling-available

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Copy link
Contributor

@thomasdesr thomasdesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to improve the tests, but otherwise lgtm!

python/ray/tests/test_cli.py Outdated Show resolved Hide resolved
python/ray/util/check_open_ports.py Outdated Show resolved Hide resolved
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@can-anyscale can-anyscale merged commit 4172f75 into ray-project:master Apr 3, 2024
4 of 5 checks passed
@jjyao jjyao deleted the jjyao/port branch April 3, 2024 21:54
@can-anyscale
Copy link
Collaborator

likely broke https://github.com/orgs/anyscale/projects/76/views/1?pane=issue&itemId=58642206, i'm reverting to unblock

can-anyscale added a commit that referenced this pull request Apr 4, 2024
can-anyscale added a commit that referenced this pull request Apr 4, 2024
jjyao added a commit to jjyao/ray that referenced this pull request Apr 5, 2024
@jjyao jjyao mentioned this pull request Apr 5, 2024
8 tasks
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants